chore: object names added for keycard controller el… #12583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentina1133
force-pushed
the
chore/keycard_controller_object_names
branch
from
95d48f2
to
2fe93cc
Compare
Valentina1133
changed the title
Valentina1133
force-pushed
the
chore/keycard_controller_object_names
branch
from
2fe93cc
to
0ffa3d9
Compare
anastasiyaig
requested changes
Oct 30, 2023
| onTriggered: { | ||
| root.selectedState = MockedKeycardReaderStateSelector.State.NoReader | ||
| } | ||
| } | ||
|
|
||
| StatusAction { | ||
| text: d.readerStateKeycardNotInserted | ||
| objectName: "readerStateReaderUnplugged" |
There was a problem hiding this comment.
it duplicates the value in line 66
| onTriggered: { | ||
| root.selectedState = MockedKeycardStateSelector.State.KeycardWithMnemonicAndMedatada | ||
| } | ||
| } | ||
|
|
||
| StatusAction { | ||
| text: d.kcStateCustomKeycard | ||
| objectName: "customKeycardItem" |
There was a problem hiding this comment.
maybe better to end with Action for this one and for others with StatusAction component?
There was a problem hiding this comment.
Suggested change
| objectName: "customKeycardItem" | |
| objectName: "customKeycardAction" |
There was a problem hiding this comment.
changed everywhere for status action
| @@ -193,6 +201,7 @@ ApplicationWindow { | |||
|
|
|||
| StatusInput { | |||
| id: mockedKeycardHelper | |||
| objectName: "specificKeycardDetailsInputField" | |||
There was a problem hiding this comment.
Suggested change
| objectName: "specificKeycardDetailsInputField" | |
| objectName: "specificKeycardDetailsInput" |
Jenkins Builds
|
Valentina1133
force-pushed
the
chore/keycard_controller_object_names
branch
from
0ffa3d9
to
355eafd
Compare
anastasiyaig
approved these changes
Oct 30, 2023
squ1sher
approved these changes
Oct 30, 2023
saledjenic
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added object names for keycard controller elements for tests automation purposes